Add assertions for testing response against JSON Schema from API resource #3003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Aug 20, 2019
teohhanhui
reviewed
Aug 20, 2019
teohhanhui
force-pushed
the
resource_json_schema_assertion
branch
from
2c94ac4 to
450627e
Compare
teohhanhui
changed the title
teohhanhui
force-pushed
the
resource_json_schema_assertion
branch
2 times, most recently
from
3a2a0bd to
4b3afaf
Compare
teohhanhui
reviewed
Aug 24, 2019
teohhanhui
force-pushed
the
resource_json_schema_assertion
branch
4 times, most recently
from
87c6b02 to
750959a
Compare
teohhanhui
force-pushed
the
resource_json_schema_assertion
branch
2 times, most recently
from
bba5ffa to
3ba1589
Compare
|
The Travis failures for Elasticsearch are... weird. The same Behat tests pass on CircleCI. |
dunglas
previously requested changes
Aug 28, 2019
src/Bridge/Symfony/Bundle/Test/Constraint/MatchesJsonSchema.php
Outdated
Show resolved
Hide resolved
| 'type' => 'integer', | ||
| 'minimum' => 1, | ||
| 'type' => 'string', | ||
| 'format' => 'iri-reference', |
There was a problem hiding this comment.
I wasn't aware of the existence of iri-reference! We should use it everywhere we know that an IRI will be generated!
There was a problem hiding this comment.
@dunglas Do you have any in mind? (We could do it in another PR.)
There was a problem hiding this comment.
he means in the rest of the core I guess (tests?), so def another pr!
teohhanhui
force-pushed
the
resource_json_schema_assertion
branch
2 times, most recently
from
f9f9dd4 to
62fa278
Compare
teohhanhui
force-pushed
the
resource_json_schema_assertion
branch
2 times, most recently
from
ac5fec5 to
ddebb8b
Compare
teohhanhui
force-pushed
the
resource_json_schema_assertion
branch
from
ddebb8b to
07e0c58
Compare
soyuka
reviewed
Sep 13, 2019
src/Bridge/Symfony/Bundle/Test/Constraint/MatchesJsonSchema.php
Outdated
Show resolved
Hide resolved
teohhanhui
force-pushed
the
resource_json_schema_assertion
branch
2 times, most recently
from
4bdb552 to
c4da141
Compare
dunglas
reviewed
Sep 19, 2019
src/Bridge/Symfony/Bundle/Test/Constraint/MatchesJsonSchema.php
Outdated
Show resolved
Hide resolved
dunglas
approved these changes
Sep 19, 2019
teohhanhui
force-pushed
the
resource_json_schema_assertion
branch
from
c4da141 to
4df2add
Compare
teohhanhui
reviewed
Sep 19, 2019
| * | ||
| * Specifically, we need to ensure that a JSON object is represented as a PHP object, not as an associative array. | ||
| */ | ||
| private function normalizeJson($document) |
There was a problem hiding this comment.
We support validating any JSON document against a JSON Schema now. 🎉
…urce Co-authored-by: Teoh Han Hui <[email protected]>
teohhanhui
force-pushed
the
resource_json_schema_assertion
branch
from
4df2add to
4489cd6
Compare
teohhanhui
reviewed
Sep 19, 2019
| "guzzlehttp/guzzle": "^6.0", | ||
| "jangregor/phpstan-prophecy": "^0.4.2", | ||
| "justinrainbow/json-schema": "^5.0", | ||
| "justinrainbow/json-schema": "^5.2.1", |
There was a problem hiding this comment.
|
Simplified the implementation a little. |
|
thanks @meyerbaptiste @teohhanhui ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.